Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Custom Cytoscape Styles #538

Merged
merged 10 commits into from
Jul 6, 2023
Merged

Add Custom Cytoscape Styles #538

merged 10 commits into from
Jul 6, 2023

Conversation

rob-gordon
Copy link
Member

@rob-gordon rob-gordon commented Jun 30, 2023 •
edited
Loading

Pull-request Checklist

🚨 Don't forget to Squash & Merge

  • Docs updated
  • QA on mobile
  • Dark Mode
  • GA Instrumentation
  • Translations

@linear
Copy link

linear bot commented Jun 30, 2023

FF-301 Add Custom Cytoscape Styling

  • Complete Styles are stored under `cytoscapeStyle` key ✅
  • User can edit style ✅
  • Can import fonts via mounting and listening to non cytoscape style ✅
  • Need to make sure that our getSize function is using the right font size style, etc to discover the size ✅
  • Themes encapsulate all needed styles ✅
    • When the user has a theme, we auto convert it inline styling ✅
      • Need to convert each current theme to a text theme ✅
  • Changing themes warns user if theme style not equal to current style
    • Check that container styles for every theme are applied correctly
      • Add Load Theme Button
  • Remove usage of theme data from
  • Autocomplete for Cytoscape styling

@vercel
Copy link

vercel bot commented Jun 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowchart-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 6:37pm

@rob-gordon rob-gordon marked this pull request as ready for review July 6, 2023 18:52
@rob-gordon rob-gordon added this pull request to the merge queue Jul 6, 2023
Merged via the queue into dev with commit edeb0c5 Jul 6, 2023
@rob-gordon rob-gordon deleted the robgordon/ff-301-add-custom-cytoscape-styling branch July 6, 2023 18:57
@rob-gordon rob-gordon mentioned this pull request Jul 7, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rob-gordon